Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport: 1.7.x] xds: version sniff envoy and switch regular expressions from 'regex' to 'safe_regex' on newer envoy versions #8266

Merged
merged 12 commits into from
Jul 9, 2020
Merged

[backport: 1.7.x] xds: version sniff envoy and switch regular expressions from 'regex' to 'safe_regex' on newer envoy versions #8266

merged 12 commits into from
Jul 9, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jul 8, 2020 •
edited
Loading

cherry-pick of #8222 onto origin/release/1.7.x

Fixes: #8205

@rboyer
xds: version sniff envoy and switch regular expressions from 'regex' …
993864f 
…to 'safe_regex' on newer envoy versions

- cut down on extra node metadata transmission
- split the golden file generation to compare all envoy version
@rboyer rboyer requested a review from a team July 8, 2020 15:14
@rboyer rboyer self-assigned this Jul 8, 2020
@rboyer rboyer merged commit 1b7a8ba into release/1.7.x Jul 9, 2020
@rboyer rboyer deleted the envoy-versions-1.7 branch July 9, 2020 22:04
@hamishforbes hamishforbes mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

Assignees

@rboyer rboyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rboyer @freddygv